Skip to content

NO TICKET: get transfer branch in pre-production | data validations#128

Merged
jirhiker merged 46 commits into
pre-productionfrom
jab-transfer-logging
Sep 12, 2025
Merged

NO TICKET: get transfer branch in pre-production | data validations#128
jirhiker merged 46 commits into
pre-productionfrom
jab-transfer-logging

Conversation

@jacob-a-brown

@jacob-a-brown jacob-a-brown commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • pull data from GPC buckets
  • address data needs to be validated by pydantic
  • errors need to be logged

How

Implementation summary - the following was changed / added / removed:

  • merge transfer into logging branch
  • use pydantic to validate addresses
  • redirect std errors to the logger for transfers

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

jirhiker and others added 30 commits September 3, 2025 08:51
@jirhiker
feat: created transfer branch for cloud build
a3a2205
@jirhiker @actions-user
Formatting changes
1e4665b
@jirhiker
feat: update asset transfer logic to handle filenames correctly
d9b0488
@jirhiker @actions-user
Formatting changes
0689d77
@jirhiker
Merge branch 'pre-production' into transfer
37d691b 
# Conflicts:
#	transfers/util.py
@jirhiker
feat: update contact transfer logic to extract roles from OwnerCommen…
0b6e98c 
…t. added todos
@jirhiker @actions-user
Formatting changes
3cdd19b
@jirhiker
feat: update contact and group transfer logic to use new CSV filename…
197c061 
…s and improve error handling
@jirhiker @actions-user
Formatting changes
3907d7a
@jirhiker
feat: add health check endpoint and middleware for improved service m…
ff6c51b 
…onitoring
@jirhiker @actions-user
Formatting changes
bdad4d9
@jirhiker
feat: add FastAPI entrypoint with trigger endpoint for transfer service
6398a02
@jirhiker @actions-user
Formatting changes
5cc8fae
@jirhiker
feat: add main entry point for FastAPI application with configurable …
fda9d27 
…port
@jirhiker @actions-user
Formatting changes
9ca5c14
@jirhiker
feat: remove uvicorn entrypoint and add Procfile for Gunicorn deployment
a4dce0c
@jirhiker @actions-user
Formatting changes
0fdb227
@jirhiker
feat: update Procfile to use UvicornWorker for Gunicorn deployment
9f515b5
@jirhiker
feat: add requirements_transfer.txt for transfer service dependencies
007bdc7
@jirhiker
feat: add requirements.txt for transfer service dependencies
53e8f6d
@jirhiker
feat: add psycopg-binary dependency to pyproject.toml and update lock…
d316cd7 
… files
@jirhiker
feat: simplify requirements.txt by removing direct file references
e182688
@jirhiker
feat: use uv requirements
3c1b91a
@jirhiker
feat: update psycopg dependencies to use psycopg2-binary and remove p…
b19e53f 
…act-python
@jirhiker
Merge branch 'pre-production' into transfer
64e36c0 
# Conflicts:
#	transfers/contact_transfer.py
@jirhiker @actions-user
Formatting changes
986e6b2
@jirhiker
feat: update Procfile to use transfers.entrypoint for web server
7f06627 
feat: add set_secrets.sh to .gitignore
@jirhiker
Merge branch 'pre-production' into transfer
db8967d 
# Conflicts:
#	transfers/contact_transfer.py
@jirhiker
feat: enhance contact transfer logic and reduce batch limit
14a9961
@jirhiker @actions-user
Formatting changes
a182088
jirhiker and others added 15 commits September 5, 2025 00:09
@jirhiker
feat: add wells endpoint and health check to transfer service
bd9bc86
@jirhiker @actions-user
Formatting changes
936814e
@jirhiker
feat: add wells endpoint and health check to transfer service
0b09d6b
@jirhiker
feat: update wells endpoint to support pagination with start index an…
ee11ade 
…d limit
@jirhiker @actions-user
Formatting changes
6bc8f69
@jirhiker
feat: update health check endpoint to use POST method with JSON payload
764e39f
@jirhiker
feat: add multiple transfer endpoints for assets, contacts, groups, a…
37543c4 
…nd more
@jirhiker @actions-user
Formatting changes
c6d8836
@jacob-a-brown
Merge branch 'transfer' into jab-transfer-logging
909ee35
@jacob-a-brown
fix: set dtype for OSEWelltagID
49225bf
@jacob-a-brown
feat: redirect errors to log
b0d1338
@jacob-a-brown
fix: set limit correctly for well transfer
8087192
@jacob-a-brown
fix: remove print debugging statement
076c024
@jacob-a-brown
Merge branch 'transfer' into jab-transfer-logging
3a8c042
@jacob-a-brown
feat: validate addresses with pydantic
5e7a2c2
@jirhiker

jirhiker commented Sep 11, 2025

Copy link
Copy Markdown
Member

Sorry for the miscommunication. I don't think transfer needs to be merged into pre-production. pre-production needs to be merged into transfer.

For this repo, we will maintain 3 branches: production, staging, and transfer. Commits made to staging will then be merged into production and transfer via PRs. Much of the transfer code is independent of the main purpose of the repo i.e., being an API, so I don't want it cluttering the production or staging branches

@jacob-a-brown

jacob-a-brown commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

I do like that I can pull the csv tables from the GCP bucket now. It makes the repo a lot cleaner and is one source of truth for the data. For this PR I'm happy to leave everything in there, but remove the entrypoint.py script from transfers/. (Would that, however, remove that when staging gets merged in transfers?)

@codecov-commenter

codecov-commenter commented Sep 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/gcs_helper.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
main.py 95.55% <100.00%> (+0.20%) ⬆️
services/gcs_helper.py 70.90% <0.00%> (-2.68%) ⬇️

@jirhiker jirhiker merged commit d19fc51 into pre-production Sep 12, 2025
3 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the jab-transfer-logging branch February 5, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jirhiker jirhiker jirhiker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacob-a-brown @jirhiker @codecov-commenter